Vite: Use mdx2 babel pre-processing #20241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! |
ndelangen
reviewed
Dec 14, 2022
| @@ -46,33 +30,16 @@ export function mdxPlugin(options: Options): Plugin { | |||
| }, | |||
| }); | |||
|
|
|||
| const mdxCode = String( | |||
| const code = String( | |||
| await compile(src, { | |||
| skipCsf: !isStorybookMdx(id), | |||
| ...mdxLoaderOptions, | |||
There was a problem hiding this comment.
Where should they come from? Is this something we want the user to be able to set? If so, why?
There was a problem hiding this comment.
Yeah, I recon we want to get them from a similar place as mdxCompilerOptions: from a preset value.
Would you like me to pick that up? I can likely get that done by end-of-day.
|
@IanVS @ndelangen this is great. merging this for now and @ndelangen you can take that in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
This incorporates storybookjs/mdx2-csf#30 into the vite builder, removing the use of the vite react-plugin, freeing us to support vite 3 and 4!
Note: we'll want to update the version of
mdx2-csfonce the referenced PR is merged / released.How to test
I tested this out by creating a react sandbox, and testing both build and dev. HMR even seems to work in dev!