-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon Outline: Fix additional outline border in docs mode #21773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @g-cappai thanks a lot for your contribution! I think we should make some slight changes to make this more reliable.
What about we add a data-story-block="true"
to the Story block, and then we target that selector instead?
Hi @yannbf , I totally agree. Now it looks definitely better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you so much for working through the feedback!
cc @JReinhold in case you want to take a look at this
@yannbf I'm sorry I'm late to the party here, but given that the story block already has a unique class |
In my perspective the data attribute is safer because the classname could be changed in the future and the person might not realize its connection to the addon outline, that's why I suggested it! Also feels more descriptive than a |
Addon Outline: Fix additional outline border in docs mode
Closes #21328
What I did
I changed the selector used to target elements to be outlined.
Now every descendant of the direct child of the ZoomElement component is outlined according to its type.
How to test
See issue -> to reproduce.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]