-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inline story style #21870
Fix inline story style #21870
Conversation
Hey @0916dhkim Thank you so much for your contribution! Great catch 🚀 |
@yannbf Happy to contribute! By the way, what would be the best way to find other Storybook issues that are first-time friendly? I'm regularly organizing public mob programming sessions at TorontoJS community, and there are many developers who are interested in open-source contribution. In fact, this PR was created during one of those sessions 😄 TorontoJS is a non-profit 100% volunteer-run community, so any advice or support is appreciated. Hope I can contribute more to Storybook! |
Ah that is amazing to know! @usrrname @winkerVSbecks you might even know @0916dhkim! |
Yep @0916dhkim runs our mob-programming style JS Code Club, it's awesome! |
screaming! two of my favourite things working together! haha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you so much! 🥳
Closes #21831
What I did
<InlineStory>
component has a typo in its inline css where it selects ID for the story block. This PR fixes the typo.How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]