Fix tsconfig resolution in Nextjs projects #22160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
I have fixed the way how we try to resolve the app's
tsconfig.json
. In monorepositories very likely each app/lib has its own tsconfig file, which extends the base root config. In this case, we DON'T want to load the root tsconfig file, but the app/lib config file instead. The resolution algorithm now searches for the following paths in the mentioned order:<cwd>/<project>/.storybook/tsconfig.json
<cwd>/<project>/tsconfig.json
<cwd>/tsconfig.json
How to test
@storybook/nextjs
dist folder into project.npx nx build-storybook next-app
shouldn't failChecklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]