Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Use next branch for sandbox and repro commands #22238

Merged
merged 1 commit into from
May 1, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 24, 2023

Closes #

What I did

As part of the 7.0.0 next to main merge process, we changed the sandbox generation to refer to themain branch, but we forgot to bring it back to next! 😮‍💨

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added the build Internal-facing build tooling & test updates label Apr 24, 2023
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to run it differently on main/next branches?

@yannbf
Copy link
Member Author

yannbf commented Apr 24, 2023

do we need to run it differently on main/next branches?

I'm not sure if I got the question right, but:

If we run the sandbox task in main branch of the monorepo, we should run sandbox --branch=main so we download the before-storybook directory of the main branch of the sandboxes repo repo, which was generated by sandbox-templates.ts of the main branch of the monorepo.

If we run the sandbox task in next branch of the monorepo, we should run sandbox --branch=next so we download the before-storybook directory of the next branch of the sandboxes repo repo, which was generated by sandbox-templates.ts of the next branch of the monorepo.

@shilman
Copy link
Member

shilman commented Apr 25, 2023

@yannbf if we run it differently on the main/next branches why is changing the default in this PR important? or an alternative question is why did we change it in the first place?

@yannbf
Copy link
Member Author

yannbf commented Apr 25, 2023

@yannbf if we run it differently on the main/next branches why is changing the default in this PR important? or an alternative question is why did we change it in the first place?

I was saying what should happen, not what happens. Currently, both main and next branches are running sandbox --branch=main.

As for the alternative question, I explained it in the description of this PR:
As part of the 7.0.0 next to main merge process, we changed the sandbox generation to refer to the main branch, but we forgot to bring it back to next! 😮‍💨

@shilman shilman changed the title Build: use next branch for sandbox and repro commands Build: Use next branch for sandbox and repro commands May 1, 2023
@shilman shilman merged commit 4a1fa3d into next May 1, 2023
@shilman shilman deleted the chore/fix-sandboxes-branch branch May 1, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants