-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: virtual modules excluded for babel-loader #22331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the right approach! Do we need to do similar for Vite do you think?
@tmeasday I don't know if vite suffers from the same problem, I though it didn't.. I was thinking that maybe there would be a need to add some sort of loader for ONLY these entries, possibly an It seems though that it's not needed, considering the sandboxes are working?! |
I think that's right. As I said, it's very simple handwritten JS. I guess we just need to be slightly careful we don't use any advanced JS in there, but I think by the nature of being JS (not TS) that's not likely.
I guess Vite is not going to suffer from this exact problem (the stripped comment is for webpack after all), so I guess you are right. |
I marked this ready for review then. |
Fix: virtual modules excluded for babel-loader
Closes #22300
What I did
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]