Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upgrade): dont upgrade nx packages #22419

Merged
merged 2 commits into from
May 22, 2023
Merged

fix(upgrade): dont upgrade nx packages #22419

merged 2 commits into from
May 22, 2023

Conversation

mandarini
Copy link
Contributor

@mandarini mandarini commented May 5, 2023 •
edited by yannbf
Loading

What I did

When upgrading, do not upgrade the @nrwl/storybook and @nx/storybook packages.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@mandarini mandarini self-assigned this May 5, 2023
@mandarini mandarini requested review from shilman and yannbf May 5, 2023 14:35
yannbf
yannbf reviewed May 5, 2023
View reviewed changes
code/lib/cli/src/upgrade.ts Outdated Show resolved Hide resolved
@mandarini mandarini requested a review from yannbf May 5, 2023 14:40
yannbf
yannbf approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yannbf yannbf added maintenance User-facing maintenance tasks cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 5, 2023
@mandarini mandarini force-pushed the fix/dont-upgrade-nx branch 2 times, most recently from ea52c6b to 5aa1ea5 Compare May 5, 2023 15:51
@mandarini
Copy link
Contributor Author

@yannbf I updated the code so as not to override the existing rejects flag! Sorry about that oversight!

mandarini
mandarini commented May 5, 2023
View reviewed changes
code/lib/cli/src/upgrade.ts Outdated Show resolved Hide resolved
@mandarini mandarini force-pushed the fix/dont-upgrade-nx branch 2 times, most recently from e37fe62 to 81b3f6e Compare May 5, 2023 16:38
@mandarini
Copy link
Contributor Author

mandarini commented May 18, 2023 •
edited
Loading

Hello @yannbf ! Is this good to go, after my latest updates?

@ndelangen
Copy link
Member

I'm looking at this today @mandarini

@ndelangen ndelangen merged commit 1853caa into next May 22, 2023
@ndelangen ndelangen deleted the fix/dont-upgrade-nx branch May 22, 2023 12:26
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 22, 2023
shilman pushed a commit that referenced this pull request May 22, 2023
@ndelangen @shilman
Merge pull request #22419 from storybookjs/fix/dont-upgrade-nx
fd40a2b 
fix(upgrade): dont upgrade nx packages
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@yannbf yannbf yannbf approved these changes

@shilman shilman Awaiting requested review from shilman

Assignees

@mandarini mandarini

Labels
cli maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mandarini @ndelangen @yannbf @shilman