Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Fix .mp3 support for builder-manager #22699

Merged
merged 1 commit into from
May 23, 2023
Merged

UI: Fix .mp3 support for builder-manager #22699

merged 1 commit into from
May 23, 2023

Conversation

ndelangen
Copy link
Member

Closes #22104

What I did

Added .mp3 files to the list of loaders

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen self-assigned this May 23, 2023
@ndelangen ndelangen added feature request builder-manager patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 23, 2023
@ndelangen ndelangen changed the title add mp3 support to builder-manager add .mp3 support to builder-manager May 23, 2023
@ndelangen ndelangen requested a review from yannbf May 23, 2023 15:15
@shilman shilman changed the title add .mp3 support to builder-manager UI: Fix .mp3 support for builder-manager May 23, 2023
shilman
shilman approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ndelangen 🙏

@shilman shilman merged commit 781b687 into next May 23, 2023
@shilman shilman deleted the norbert/mp3-support-manager-builder branch May 23, 2023 15:36
@shilman shilman mentioned this pull request May 23, 2023
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 23, 2023
shilman added a commit that referenced this pull request May 23, 2023
@shilman
Merge pull request #22699 from storybookjs/norbert/mp3-support-manage…
b6c9824 
…r-builder

UI: Fix `.mp3` support for builder-manager
This was referenced May 23, 2023
Closed
Merged
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@yannbf yannbf Awaiting requested review from yannbf

Assignees

@ndelangen ndelangen

Labels
builder-manager feature request patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: v7.0.4 'No loader is configured for ".eot"
2 participants
@ndelangen @shilman