-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React: Update babel dependencies to fix sandbox creation #22824
Conversation
thanks @ndelangen ❤️ i will merge it |
Running into svelte check issues. I have no idea how to resolve that. |
i checking out your PR, i will give a shot with svelte |
Thank you @chakAs3 that would be appreciated! We can try to work out what got updated that makes it break, perhaps there's now multiple versions of a package that we had only 1 of before? Or we can try to work out what's wrong and fix it. |
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again. Bot CommandsTo ignore an alert, reply with a comment starting with
📜 Install scriptsInstall scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.
Pull request alert summary
📊 Modified Dependency Overview:
|
Thank you for helping getting this over the line on your weekend @kasperpeulen @chakAs3 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndelangen this updates a bunch of user-facing code, so it should NOT be labeled as build
, which is for internal build-only changes.
OK that's fair @shilman |
No description provided.