Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing register.js file in GA addon base directory #5379

Merged
merged 1 commit into from
Jan 27, 2019
Merged

Add missing register.js file in GA addon base directory #5379

merged 1 commit into from
Jan 27, 2019

Conversation

gaetanmaisse
Copy link
Member

@gaetanmaisse gaetanmaisse commented Jan 27, 2019 •
edited
Loading

What I did

Add missing register.js file in addon-google-analytics base directory.

This file is missing since addon beginning and is needed to be able to make import as describe in README work:

import '@storybook/addon-google-analytics/register';

--

For now only import '@storybook/addon-google-analytics/dist/register'; is working.

@gaetanmaisse
Add missing register.js file in addon base directory
f619414 
This file is missing since addon beginning and is needed to be able to make import as describe in README work:

```js
import '@storybook/addon-google-analytics/register';
```
@gaetanmaisse gaetanmaisse changed the title Add missing register.js file in addon base directory Add missing register.js file in GA addon base directory Jan 27, 2019
@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against f619414

@shilman shilman added the maintenance User-facing maintenance tasks label Jan 27, 2019
shilman
shilman approved these changes Jan 27, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@shilman shilman merged commit f98edcb into storybookjs:next Jan 27, 2019
@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch and removed maintenance User-facing maintenance tasks labels Jan 27, 2019
@gaetanmaisse gaetanmaisse deleted the fix/addon-google-analytics-register branch January 27, 2019 17:00
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 18, 2019
shilman added a commit that referenced this pull request Feb 18, 2019
@shilman
Merge pull request #5379 from gaetanmaisse/fix/addon-google-analytics…
67252c9 
…-register

Add missing `register.js` file in GA addon base directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaetanmaisse @storybook-safe-bot @shilman