Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX register form policyId and amount field error #23

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

cnych
Copy link

@cnych cnych commented Feb 26, 2024

fix register page policyId is optional on Register IP Asset form.

fix register page amount should number, but received string on Mint License NFT form.

Copy link

vercel bot commented Feb 26, 2024

@cnych is attempting to deploy a commit to the Story Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@cnych cnych closed this Feb 26, 2024
@cnych cnych reopened this Feb 26, 2024
Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
protocol-explorer-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 6:17pm

Copy link
Collaborator

@allenchuang allenchuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, I think we also need to update the type check for zod on L18 to be string. Other than that it looks good!

@cnych
Copy link
Author

cnych commented Feb 26, 2024

Thanks for contributing, I think we also need to update the type check for zod on L18 to be string. Other than that it looks good!

L18 is amount: z.bigint(),, need update amount to string type? Is the type received by the background string? Normally it should be int, right?

@allenchuang
Copy link
Collaborator

You're right in that it should be int. But the input field that is dynamically generated by default takes type string we will have to convert and parse to BigInt once submitted.

@cnych
Copy link
Author

cnych commented Feb 26, 2024

You're right in that it should be int. But the input field that is dynamically generated by default takes type string we will have to convert and parse to BigInt once submitted.

I see, has update the amount type to string.

Copy link
Collaborator

@allenchuang allenchuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@allenchuang allenchuang merged commit 2e70df4 into storyprotocol:beta Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants