src: Move backend-internal error handling into separate files #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #361 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 31 31
Lines 2421 2421
=======================================
Hits 2354 2354
Misses 67 67 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal error handling in the CUDA and HIP backends was previously an internal detail of the
memorybackend implementation. However, this functionality is also required in thedeviceimplementations and currently causes a compiler warning in the HIP backend due to an unhandled return variable. Move the error handling code to a dedicated backend-specific file and use it in both thememoryand thedevicemodules.