Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory: Remove obsolete uninitialized memory functions #365

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

stotko
Copy link
Owner

@stotko stotko commented Jun 16, 2023

Now that all containers use the allocator_traits API, the previous {create,destroy}{Device,Host,Managed}Array functions as part of the internal helper functions are no longer used. Furthermore, they all redundantly map to the same functions. Thus, remove them altogether to clean up the implementation of the memory module.

@stotko stotko added this to the 2.0.0 milestone Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b824d9f) 97.29% compared to head (9f1d532) 97.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files          31       31           
  Lines        2480     2480           
=======================================
  Hits         2413     2413           
  Misses         67       67           
Impacted Files Coverage Δ
src/stdgpu/impl/memory_detail.h 99.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stotko stotko merged commit 96206ad into master Jun 16, 2023
@stotko stotko deleted the remove_uninitialized_memory_functions branch June 16, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant