Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use better aligned colors for dark mode #397

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Conversation

stotko
Copy link
Owner

@stotko stotko commented Aug 20, 2023

The dark mode of the Sphinx book theme has been modified since the port to Sphinx to reduce the excessively high contrast of the separator. and to make the background a bit brighter. To come up with better aligned colors, the contrast needs to be analyzed more thoroughly. Add a respective script for this purpose and define a better separator color while dropping the brighter background. Furthermore, prepare for using Sphinx Design and ensure consistency with these changes.

@stotko stotko added this to the 2.0.0 milestone Aug 20, 2023
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d9a4587) 97.40% compared to head (549de19) 97.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files          31       31           
  Lines        2581     2581           
=======================================
  Hits         2514     2514           
  Misses         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stotko stotko merged commit a3bd45b into master Aug 20, 2023
55 checks passed
@stotko stotko deleted the sphinx_colors branch August 20, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant