Use current Ed25519 OID #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! |
|
@jimktrains For historical note: your PR only changed the OID for encoding, not for decoding (but that's my fault for not spotting it before merging). It also turns out that the new draft is not just an OID change, but a significant formatting change; hence I should not have merged this PR before requiring further changes. However, I'm going to leave it merged so that it forces me to get this fixed 😅 |
|
Actually, on second thought I've reverted this commit (and the commit I made to change the OID for decoding), in favour of preserving the existing functions, to provide a migration path for library users. |
|
I've opened #21 to track ongoing progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference:
https://datatracker.ietf.org/doc/draft-ietf-curdle-pkix/?include_text=1