Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RecipientStanza #118

Closed
str4d opened this issue Jul 12, 2020 · 0 comments · Fixed by #120
Closed

Refactor RecipientStanza #118

str4d opened this issue Jul 12, 2020 · 0 comments · Fixed by #120

Comments

@str4d
Copy link
Owner

str4d commented Jul 12, 2020

RecipientStanza started as an enum, and we parsed the header into the exact recipient types we knew about. This worked well when we also knew the exact set of supported recipient / identity types, but since the Identity trait was introduced in #117 we no longer have complete knowledge. We need to rework the parsing, wrapping, and unwrapping logic to be based around a common Stanza type, which individual recipient / identity types parse further.

Blocks the next release, because we made the current enum-based RecipientStanza public in #117.
@str4d str4d mentioned this issue Jul 12, 2020
Merged
str4d added a commit that referenced this issue Jul 13, 2020
@str4d
age: Convert format::RecipientStanza from an enum into a struct
05028f5 
Recipient and identities now internally parse the generic stanza fields.

The new struct is exposed as age::Stanza. This might move into age-core
at some point, when it is unified with age_core::format::AgeStanza.

Closes #118.
@str4d str4d mentioned this issue Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

age: Convert format::RecipientStanza from an enum into a struct str4d/rage
1 participant
@str4d