-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overwriting existing output file #168
Conversation
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 34.90% 36.21% +1.31%
==========================================
Files 33 33
Lines 2716 2764 +48
==========================================
+ Hits 948 1001 +53
+ Misses 1768 1763 -5
Continue to review full report at Codecov.
|
IIUC, all the tests pass except uploading benchmarks - which fails with:
https://github.com/str4d/rage/pull/168/checks?check_run_id=1708942847 |
Ping :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I've been reluctant to merge it because I'm not personally a fan of just overwriting files, but after talking with @FiloSottile and some other sysadmins, I now agree that the more consistent UX is for -o
to behave the same way as pipes, i.e. do what Unix does and overwrite the output.
Thanks! |
Otherwise,
rage
fails with: