Fixed unwind safe within zip_elements
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phosphorus15
changed the title
map_elementszip_elements
|
The PR title says " |
strake
reviewed
Sep 24, 2019
src/lib.rs
Outdated
| @@ -172,13 +172,14 @@ impl<A, M: ArrayLength<A>, N: ArrayLength<GenericArray<A, M>>> Matrix<A, M, N> { | |||
| #[inline] fn map_elements<B, F: FnMut(A) -> B>(self, mut f: F) -> Matrix<B, M, N> | |||
| where M: ArrayLength<B>, N: ArrayLength<GenericArray<B, M>> { | |||
| let Matrix(a) = self; | |||
| let _wrapper = mem::ManuallyDrop::new(a); | |||
There was a problem hiding this comment.
Why the leading underscore? We use it below.
src/lib.rs
Outdated
| Matrix(c) | ||
| } | ||
|
|
Yeah, that's my fault, I'll fix this soon. |
By this I mean, they are both broken. 😂 |
|
The code reformatter might have changed the codes format .. hope you don't mind 😭 |
|
I'd prefer you not reformat the file... |
|
This should make it sound |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fixes #1 , which wraps a
ManuallyDroparound the original matrix to prevent unintentional dropping of its elements.