Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor corrections #21

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Minor corrections #21

merged 1 commit into from
Aug 22, 2018

Conversation

qw3n
Copy link
Contributor

@qw3n qw3n commented Aug 22, 2018

Added a missing = and ,

Added a missing `=` and `,`
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.01% when pulling 1af254a on qw3n:patch-1 into 32a15f3 on straker:master.

@straker straker merged commit 88dada3 into straker:master Aug 22, 2018
@straker
Copy link
Owner

straker commented Aug 22, 2018

Nice catch. Thanks for the pr.

@qw3n
Copy link
Contributor Author

qw3n commented Aug 22, 2018

No problem. One other thing that was just me not reading the data arrays correctly, but it took me forever to realize that the tilesets are 1 indexed and not 0. Perhaps explicitly stating that somewhere would be good.

@qw3n qw3n deleted the patch-1 branch August 22, 2018 15:56
@straker
Copy link
Owner

straker commented Aug 22, 2018

Good idea. I'll create an issue to add that to the docs so I don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants