Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nonce rename #165

Merged
merged 3 commits into from
Jul 6, 2023
Merged

nonce rename #165

merged 3 commits into from
Jul 6, 2023

Conversation

agouin
Copy link
Member

@agouin agouin commented Jun 28, 2023 •
edited
Loading

  • rename EphemeralSecretPart -> Nonce
  • rename EphemeralPublic -> NoncePublic
  • other minor renames
  • improve some comments

@agouin agouin marked this pull request as ready for review June 28, 2023 21:08
mark-rushakoff
mark-rushakoff approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@mark-rushakoff mark-rushakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforward rename.

signer/cosigner.go Outdated Show resolved Hide resolved
signer/metrics.go
@@ -134,7 +134,7 @@ var (
Help: "Seconds Since Last Local Finish Sign (Should stay below 2 * Block Time)",
})

secondsSinceLastLocalEphemeralShareTime = promauto.NewGauge(prometheus.GaugeOpts{
secondsSinceLastLocalNonceTime = promauto.NewGauge(prometheus.GaugeOpts{
Name: "signer_seconds_since_last_local_ephemeral_share_time",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it too late to change the prometheus metric names? Do they need to be changed to use nonce too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I avoided these since it would be a breaking change. We aren't yet consuming these in our metrics stack but other validators are.

@agouin agouin merged commit 788974c into main Jul 6, 2023
@agouin agouin deleted the andrew/nonce_rename branch July 6, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-rushakoff mark-rushakoff mark-rushakoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agouin @mark-rushakoff