waiting for same block signature - timeout and max attempts #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agouin
force-pushed
the
andrew/cond_timeout_and_max_attempts
branch
from
a19221a
to
a2855a2
Compare
mark-rushakoff
approved these changes
Jul 24, 2023
| @@ -188,6 +192,11 @@ func (pv *ThresholdValidator) SaveLastSignedStateInitiated(chainID string, block | |||
| "latest_step", latest.Step, | |||
| ) | |||
| } | |||
|
|
|||
| return nil, existingTimestamp, fmt.Errorf( | |||
There was a problem hiding this comment.
It doesn't look like there is a test covering this error case, and it seems important to ensure we properly handle the timeout case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync.CondWait()does not allow a timeout to be specified. It will wait forever until a goroutineBroadcast()s to wake it up.https://gist.github.com/zviadm/c234426882bfc8acba88f3503edaaa36#file-cond2-go
This cond implementation uses a channel that can be closed, and a new channel to replace it each time, allowing a timeout to be used.