Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no concurrent dial to same node #186

Merged
merged 6 commits into from
Jul 31, 2023
Merged

Conversation

agouin
Copy link
Member

@agouin agouin commented Jul 27, 2023

concurrent dials can cause infinite retries.

simplifies connect loop to use context timeout only, ensuring synchronous completion before retrying next connection attempt

@agouin agouin marked this pull request as ready for review July 27, 2023 17:46
signer/remote_signer.go Show resolved Hide resolved
signer/remote_signer.go Outdated Show resolved Hide resolved
signer/remote_signer.go Show resolved Hide resolved
signer/remote_signer.go Show resolved Hide resolved
signer/remote_signer.go Show resolved Hide resolved
@agouin agouin merged commit 1944d3d into main Jul 31, 2023
12 checks passed
@agouin agouin deleted the andrew/no_concurrent_dial_to_same_node branch July 31, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants