Fix stuck leader when cosigner goes down #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a cosigner goes down, all nonces may need to be cleared. In the case that horcrux is serving multiple chains, this means that
GetNonces
may be called repetitively when the nonce cache is empty. When this happens, we do not want it to block, it should return immediately.Additionally, this scenario was queuing up many items in the
empty
channel which would cause rapid back to backreconcile
s to occur, which could lead to massive numbers of nonces being requested due to the incrementinglastReconcileNonces
and such short duration sincelastReconcileTime
. We only need to enqueue at most 1 item in the empty channel. Due to race conditions on the channel len check, The buffer is oversized.