Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not encode double quotes from font-family as `""" #129

Closed
Stranger6667 opened this issue Jan 8, 2022 · 2 comments · Fixed by #130
Closed

Do not encode double quotes from font-family as `""" #129

Stranger6667 opened this issue Jan 8, 2022 · 2 comments · Fixed by #130
Labels
Type: Bug

Comments

@Stranger6667
Copy link
Owner

From W3Schools:

Note: If a font name contains white-space, it must be quoted. Single quotes must be used when using the "style" attribute in HTML.

Currently h1 { font-family: "Open Sans", sans-serif; } will be inlined as style="font-family: "Open Sans", sans-serif;"
Stranger6667 added a commit that referenced this issue Jan 8, 2022
@Stranger6667
fix: Invalid handling of double-quoted property values like in `font-…
d14a5b3 
…family: "Open Sans"`

Ref: #129
@Stranger6667 Stranger6667 mentioned this issue Jan 8, 2022
Merged
Stranger6667 added a commit that referenced this issue Jan 8, 2022
@Stranger6667
fix: Invalid handling of double-quoted property values like in `font-…
150f3be 
…family: "Open Sans"`

Ref: #129
Stranger6667 added a commit that referenced this issue Jan 8, 2022
@Stranger6667
fix: Invalid handling of double-quoted property values like in `font-…
914d9d6 
…family: "Open Sans"`

Ref: #129
@Elendiar
Copy link

image

that's probably why this happened to me with bootstrap (

@Stranger6667
Copy link
Owner Author

Stranger6667 commented Nov 27, 2023 •
edited
Loading

It looks like it is not in font-family - probably we need to process all attributes this way, not just font-family. Originally it was done only for font-family due to performance hit of the ‘“‘ lookup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Invalid handling of double-quoted property values Stranger6667/css-inline
2 participants
@Stranger6667 @Elendiar