Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Husky broken on windows #16645

Open
Boegie19 opened this issue May 8, 2023 · 0 comments
Open

Husky broken on windows #16645

Boegie19 opened this issue May 8, 2023 · 0 comments
Labels
issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: tooling Source is GitHub tooling/tests/ect status: confirmed Confirmed by a Strapi Team member or multiple community members

Comments

@Boegie19
Copy link
Collaborator

Boegie19 commented May 8, 2023

Bug report

Required System information

  • Node.js version: v18.9.1
  • NPM version: 8.19.1
  • Strapi version: not relevant since it is a repo issue
  • Database: not relevant since it is a repo issue
  • Operating system: windows 10
  • Is your project Javascript or Typescript: not relevant since it is a repo issue

Describe the bug

Husky pre commit hook broken causing me to not be able to comit on windows unless I reomve the pre-commit hook

Steps to reproduce the behavior

  1. be on windows
  2. make a change to a file
  3. try to commit to strapi
  4. get following error

Expected behavior

for husky to not error and for me to be able to comit

Screenshots

b9e1293f60e525036c939095b8731844
@Boegie19 Boegie19 added issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: tooling Source is GitHub tooling/tests/ect status: confirmed Confirmed by a Strapi Team member or multiple community members labels May 8, 2023
@Boegie19 Boegie19 mentioned this issue Oct 11, 2023
Merged
joshuaellis added a commit that referenced this issue Oct 13, 2023
@joshuaellis
chore(tooling): add commitlint (#18402)
877f930 
resolves #16645
@alexandrebodin alexandrebodin mentioned this issue Oct 13, 2023
Merged
1 task
@joshuaellis joshuaellis mentioned this issue Oct 17, 2023
Merged
@alexandrebodin alexandrebodin mentioned this issue Oct 18, 2023
Merged
joshuaellis added a commit that referenced this issue Oct 24, 2023
@joshuaellis
chore(tooling): add commitlint (#18402)
19859af 
resolves #16645
joshuaellis added a commit that referenced this issue Oct 24, 2023
@joshuaellis
chore(tooling): add commitlint (#18402)
b056d71 
resolves #16645
innerdvations pushed a commit that referenced this issue Oct 26, 2023
@joshuaellis @innerdvations
chore(tooling): add commitlint (#18402)
f8fd9a1 
resolves #16645
innerdvations pushed a commit that referenced this issue Oct 26, 2023
@joshuaellis @innerdvations
chore(tooling): add commitlint (#18402)
872ee52 
resolves #16645
innerdvations added a commit that referenced this issue Oct 30, 2023
@innerdvations
chore: only support better-sqlite3 package for sqlite (#18500)
6d4417f 
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
resolves #16645
innerdvations pushed a commit that referenced this issue Oct 30, 2023
@joshuaellis @innerdvations
chore(tooling): add commitlint (#18402)
7904cac 
resolves #16645
innerdvations pushed a commit that referenced this issue Oct 30, 2023
@joshuaellis @innerdvations
chore(tooling): add commitlint (#18402)
82a243a 
resolves #16645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: tooling Source is GitHub tooling/tests/ect status: confirmed Confirmed by a Strapi Team member or multiple community members
Projects
Support team
Status: Reproducible on v4
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Boegie19