[v5] Only support better-sqlite3 package for sqlite #18500

innerdvations · 2023-10-19T08:55:27Z

What does it do?

removes all the legacy code for sqlite3, vscode/sqlite3, and the knex sqlite3 package.
update CI and new project generators to latest version of better-sqlite3 package

Why is it needed?

Strapi v5 will only support the better-sqlite3 package

How to test it?

Sqlite should work fine

Related issue(s)/PR(s)

Docs PR: strapi/documentation#1887

github-actions · 2023-10-19T09:10:27Z

Size Change: -55.5 kB (-4%)

Total Size: 1.48 MB

Filename	Size	Change
`packages/core/admin/build/main.********.js`	623 kB	-561 B (0%)
`packages/core/admin/build/runtime~main.********.js`	4.88 kB	-52 B (-1%)
`packages/core/admin/build/strapi-plugin-cloud.********.chunk.js`	0 B	-54.9 kB (removed)	🏆

ℹ️ View Unchanged

Filename	Size	Change
`packages/core/admin/build/Admin_homePage.********.chunk.js`	8.68 kB	0 B
`packages/core/admin/build/Admin_InternalErrorPage.********.chunk.js`	526 B	0 B
`packages/core/admin/build/Admin_marketplace.********.chunk.js`	6.37 kB	0 B
`packages/core/admin/build/Admin_pluginsPage.********.chunk.js`	1.17 kB	0 B
`packages/core/admin/build/Admin_profilePage.********.chunk.js`	3.47 kB	0 B
`packages/core/admin/build/Admin_settingsPage.********.chunk.js`	8.65 kB	0 B
`packages/core/admin/build/Admin-authenticatedApp.********.chunk.js`	8.05 kB	-1 B (0%)
`packages/core/admin/build/admin-edit-roles-page.********.chunk.js`	16.3 kB	0 B
`packages/core/admin/build/admin-edit-users.********.chunk.js`	4.05 kB	0 B
`packages/core/admin/build/admin-roles-list.********.chunk.js`	3.1 kB	0 B
`packages/core/admin/build/admin-users.********.chunk.js`	5.79 kB	0 B
`packages/core/admin/build/api-tokens-create-page.********.chunk.js`	260 B	0 B
`packages/core/admin/build/api-tokens-edit-page.********.chunk.js`	259 B	0 B
`packages/core/admin/build/api-tokens-list-page.********.chunk.js`	2.87 kB	0 B
`packages/core/admin/build/ar-json.********.chunk.js`	19.6 kB	0 B
`packages/core/admin/build/audit-logs-sales-page.********.chunk.js`	628 B	0 B
`packages/core/admin/build/audit-logs-settings-page.********.chunk.js`	4.06 kB	0 B
`packages/core/admin/build/bb3108f7fd1e6179bde1.svg`	352 B	0 B
`packages/core/admin/build/bb4d0d527bdfb161bc5a.svg`	2.33 kB	0 B
`packages/core/admin/build/ca-json.********.chunk.js`	13 kB	0 B
`packages/core/admin/build/content-manager.********.chunk.js`	71.8 kB	0 B
`packages/core/admin/build/content-type-builder-list-view.********.chunk.js`	6.35 kB	0 B
`packages/core/admin/build/content-type-builder-translation-ar-json.********.chunk.js`	1.37 kB	0 B
`packages/core/admin/build/content-type-builder-translation-cs-json.********.chunk.js`	2.89 kB	0 B
`packages/core/admin/build/content-type-builder-translation-de-json.********.chunk.js`	4.16 kB	0 B
`packages/core/admin/build/content-type-builder-translation-dk-json.********.chunk.js`	3.71 kB	0 B
`packages/core/admin/build/content-type-builder-translation-en-json.********.chunk.js`	4.12 kB	0 B
`packages/core/admin/build/content-type-builder-translation-es-json.********.chunk.js`	3.93 kB	0 B
`packages/core/admin/build/content-type-builder-translation-fr-json.********.chunk.js`	1.62 kB	0 B
`packages/core/admin/build/content-type-builder-translation-id-json.********.chunk.js`	3.3 kB	0 B
`packages/core/admin/build/content-type-builder-translation-it-json.********.chunk.js`	3.43 kB	0 B
`packages/core/admin/build/content-type-builder-translation-ja-json.********.chunk.js`	1.23 kB	0 B
`packages/core/admin/build/content-type-builder-translation-ko-json.********.chunk.js`	4.33 kB	0 B
`packages/core/admin/build/content-type-builder-translation-ms-json.********.chunk.js`	3.29 kB	0 B
`packages/core/admin/build/content-type-builder-translation-nl-json.********.chunk.js`	3.31 kB	0 B
`packages/core/admin/build/content-type-builder-translation-pl-json.********.chunk.js`	4.14 kB	0 B
`packages/core/admin/build/content-type-builder-translation-pt-BR-json.********.chunk.js`	4.13 kB	0 B
`packages/core/admin/build/content-type-builder-translation-pt-json.********.chunk.js`	1.1 kB	0 B
`packages/core/admin/build/content-type-builder-translation-ru-json.********.chunk.js`	4.63 kB	0 B
`packages/core/admin/build/content-type-builder-translation-sk-json.********.chunk.js`	3.69 kB	0 B
`packages/core/admin/build/content-type-builder-translation-sv-json.********.chunk.js`	4.14 kB	0 B
`packages/core/admin/build/content-type-builder-translation-th-json.********.chunk.js`	4.37 kB	0 B
`packages/core/admin/build/content-type-builder-translation-tr-json.********.chunk.js`	3.8 kB	0 B
`packages/core/admin/build/content-type-builder-translation-uk-json.********.chunk.js`	4.38 kB	0 B
`packages/core/admin/build/content-type-builder-translation-zh-Hans-json.********.chunk.js`	3.44 kB	0 B
`packages/core/admin/build/content-type-builder-translation-zh-json.********.chunk.js`	4.47 kB	0 B
`packages/core/admin/build/content-type-builder.********.chunk.js`	27 kB	0 B
`packages/core/admin/build/cs-json.********.chunk.js`	5.88 kB	0 B
`packages/core/admin/build/de-json.********.chunk.js`	12.8 kB	0 B
`packages/core/admin/build/dk-json.********.chunk.js`	10.5 kB	0 B
`packages/core/admin/build/email-settings-page.********.chunk.js`	2.26 kB	0 B
`packages/core/admin/build/en-json.********.chunk.js`	16.1 kB	0 B
`packages/core/admin/build/es-json.********.chunk.js`	14.2 kB	0 B
`packages/core/admin/build/eu-json.********.chunk.js`	14.2 kB	0 B
`packages/core/admin/build/fr-json.********.chunk.js`	12.6 kB	0 B
`packages/core/admin/build/gu-json.********.chunk.js`	14.2 kB	0 B
`packages/core/admin/build/he-json.********.chunk.js`	6.48 kB	0 B
`packages/core/admin/build/hi-json.********.chunk.js`	16.4 kB	0 B
`packages/core/admin/build/highlight.js.********.chunk.js`	842 B	0 B
`packages/core/admin/build/hu-json.********.chunk.js`	15.4 kB	0 B
`packages/core/admin/build/i18n-settings-page.********.chunk.js`	3.88 kB	0 B
`packages/core/admin/build/i18n-translation-de-json.********.chunk.js`	1.62 kB	0 B
`packages/core/admin/build/i18n-translation-dk-json.********.chunk.js`	1.62 kB	0 B
`packages/core/admin/build/i18n-translation-en-json.********.chunk.js`	1.57 kB	0 B
`packages/core/admin/build/i18n-translation-es-json.********.chunk.js`	1.68 kB	0 B
`packages/core/admin/build/i18n-translation-fr-json.********.chunk.js`	1.73 kB	0 B
`packages/core/admin/build/i18n-translation-ko-json.********.chunk.js`	1.86 kB	0 B
`packages/core/admin/build/i18n-translation-pl-json.********.chunk.js`	1.8 kB	0 B
`packages/core/admin/build/i18n-translation-ru-json.********.chunk.js`	2.39 kB	0 B
`packages/core/admin/build/i18n-translation-tr-json.********.chunk.js`	1.7 kB	0 B
`packages/core/admin/build/i18n-translation-zh-Hans-json.********.chunk.js`	1.64 kB	0 B
`packages/core/admin/build/i18n-translation-zh-json.********.chunk.js`	1.73 kB	0 B
`packages/core/admin/build/id-json.********.chunk.js`	7.46 kB	0 B
`packages/core/admin/build/index.html`	263 B	-1 B (0%)
`packages/core/admin/build/it-json.********.chunk.js`	7.93 kB	0 B
`packages/core/admin/build/ja-json.********.chunk.js`	12.3 kB	0 B
`packages/core/admin/build/ko-json.********.chunk.js`	11.6 kB	0 B
`packages/core/admin/build/ml-json.********.chunk.js`	17.3 kB	0 B
`packages/core/admin/build/ms-json.********.chunk.js`	6.16 kB	0 B
`packages/core/admin/build/nl-json.********.chunk.js`	14.4 kB	0 B
`packages/core/admin/build/no-json.********.chunk.js`	5.48 kB	0 B
`packages/core/admin/build/pl-json.********.chunk.js`	13.2 kB	0 B
`packages/core/admin/build/pt-BR-json.********.chunk.js`	13.9 kB	0 B
`packages/core/admin/build/pt-json.********.chunk.js`	5.71 kB	0 B
`packages/core/admin/build/review-workflows-sales-page.********.chunk.js`	594 B	0 B
`packages/core/admin/build/review-workflows-settings-create-view.********.chunk.js`	2.24 kB	0 B
`packages/core/admin/build/review-workflows-settings-edit-view.********.chunk.js`	2.53 kB	0 B
`packages/core/admin/build/review-workflows-settings-list-view.********.chunk.js`	5.26 kB	0 B
`packages/core/admin/build/ru-json.********.chunk.js`	21.6 kB	0 B
`packages/core/admin/build/sa-json.********.chunk.js`	16.9 kB	0 B
`packages/core/admin/build/sk-json.********.chunk.js`	11.8 kB	0 B
`packages/core/admin/build/sso-sales-page.********.chunk.js`	610 B	0 B
`packages/core/admin/build/sso-settings-page.********.chunk.js`	1.94 kB	0 B
`packages/core/admin/build/sv-json.********.chunk.js`	14.1 kB	0 B
`packages/core/admin/build/th-json.********.chunk.js`	9.01 kB	0 B
`packages/core/admin/build/tr-json.********.chunk.js`	13.8 kB	0 B
`packages/core/admin/build/transfer-tokens-create-page.********.chunk.js`	261 B	0 B
`packages/core/admin/build/transfer-tokens-edit-page.********.chunk.js`	262 B	0 B
`packages/core/admin/build/transfer-tokens-list-page.********.chunk.js`	3.03 kB	0 B
`packages/core/admin/build/uk-json.********.chunk.js`	7.71 kB	0 B
`packages/core/admin/build/Upload_ConfigureTheView.********.chunk.js`	1.74 kB	0 B
`packages/core/admin/build/upload-settings.********.chunk.js`	1.93 kB	0 B
`packages/core/admin/build/upload-translation-ca-json.********.chunk.js`	2.48 kB	0 B
`packages/core/admin/build/upload-translation-de-json.********.chunk.js`	2.19 kB	0 B
`packages/core/admin/build/upload-translation-dk-json.********.chunk.js`	1.96 kB	0 B
`packages/core/admin/build/upload-translation-en-json.********.chunk.js`	2.58 kB	0 B
`packages/core/admin/build/upload-translation-es-json.********.chunk.js`	2.45 kB	0 B
`packages/core/admin/build/upload-translation-fr-json.********.chunk.js`	2.86 kB	0 B
`packages/core/admin/build/upload-translation-he-json.********.chunk.js`	1.84 kB	0 B
`packages/core/admin/build/upload-translation-it-json.********.chunk.js`	1.56 kB	0 B
`packages/core/admin/build/upload-translation-ja-json.********.chunk.js`	1.92 kB	0 B
`packages/core/admin/build/upload-translation-ko-json.********.chunk.js`	2.5 kB	0 B
`packages/core/admin/build/upload-translation-ms-json.********.chunk.js`	1.41 kB	0 B
`packages/core/admin/build/upload-translation-pl-json.********.chunk.js`	2.19 kB	0 B
`packages/core/admin/build/upload-translation-pt-BR-json.********.chunk.js`	1.61 kB	0 B
`packages/core/admin/build/upload-translation-pt-json.********.chunk.js`	1.61 kB	0 B
`packages/core/admin/build/upload-translation-ru-json.********.chunk.js`	2.02 kB	0 B
`packages/core/admin/build/upload-translation-sk-json.********.chunk.js`	2.58 kB	0 B
`packages/core/admin/build/upload-translation-th-json.********.chunk.js`	1.99 kB	0 B
`packages/core/admin/build/upload-translation-tr-json.********.chunk.js`	2.35 kB	0 B
`packages/core/admin/build/upload-translation-uk-json.********.chunk.js`	1.96 kB	0 B
`packages/core/admin/build/upload-translation-zh-Hans-json.********.chunk.js`	3.12 kB	0 B
`packages/core/admin/build/upload-translation-zh-json.********.chunk.js`	2.65 kB	0 B
`packages/core/admin/build/upload.********.chunk.js`	7.12 kB	0 B
`packages/core/admin/build/users-advanced-settings-page.********.chunk.js`	2.29 kB	0 B
`packages/core/admin/build/users-email-settings-page.********.chunk.js`	2.34 kB	0 B
`packages/core/admin/build/users-permissions-translation-ar-json.********.chunk.js`	1.51 kB	0 B
`packages/core/admin/build/users-permissions-translation-cs-json.********.chunk.js`	1.46 kB	0 B
`packages/core/admin/build/users-permissions-translation-de-json.********.chunk.js`	1.58 kB	0 B
`packages/core/admin/build/users-permissions-translation-dk-json.********.chunk.js`	1.92 kB	0 B
`packages/core/admin/build/users-permissions-translation-en-json.********.chunk.js`	1.81 kB	0 B
`packages/core/admin/build/users-permissions-translation-es-json.********.chunk.js`	2.05 kB	0 B
`packages/core/admin/build/users-permissions-translation-fr-json.********.chunk.js`	1.41 kB	0 B
`packages/core/admin/build/users-permissions-translation-id-json.********.chunk.js`	1.49 kB	0 B
`packages/core/admin/build/users-permissions-translation-it-json.********.chunk.js`	1.57 kB	0 B
`packages/core/admin/build/users-permissions-translation-ja-json.********.chunk.js`	1.53 kB	0 B
`packages/core/admin/build/users-permissions-translation-ko-json.********.chunk.js`	2.23 kB	0 B
`packages/core/admin/build/users-permissions-translation-ms-json.********.chunk.js`	1.27 kB	0 B
`packages/core/admin/build/users-permissions-translation-nl-json.********.chunk.js`	1.32 kB	0 B
`packages/core/admin/build/users-permissions-translation-pl-json.********.chunk.js`	2.11 kB	0 B
`packages/core/admin/build/users-permissions-translation-pt-BR-json.********.chunk.js`	1.21 kB	0 B
`packages/core/admin/build/users-permissions-translation-pt-json.********.chunk.js`	1.3 kB	0 B
`packages/core/admin/build/users-permissions-translation-ru-json.********.chunk.js`	2.75 kB	0 B
`packages/core/admin/build/users-permissions-translation-sk-json.********.chunk.js`	1.38 kB	0 B
`packages/core/admin/build/users-permissions-translation-sv-json.********.chunk.js`	2.01 kB	0 B
`packages/core/admin/build/users-permissions-translation-th-json.********.chunk.js`	2.01 kB	0 B
`packages/core/admin/build/users-permissions-translation-tr-json.********.chunk.js`	2.07 kB	0 B
`packages/core/admin/build/users-permissions-translation-uk-json.********.chunk.js`	1.75 kB	0 B
`packages/core/admin/build/users-permissions-translation-vi-json.********.chunk.js`	1.51 kB	0 B
`packages/core/admin/build/users-permissions-translation-zh-Hans-json.********.chunk.js`	2.19 kB	0 B
`packages/core/admin/build/users-permissions-translation-zh-json.********.chunk.js`	2.1 kB	0 B
`packages/core/admin/build/users-providers-settings-page.********.chunk.js`	3.52 kB	0 B
`packages/core/admin/build/users-roles-settings-page.********.chunk.js`	6.79 kB	0 B
`packages/core/admin/build/vi-json.********.chunk.js`	5.98 kB	0 B
`packages/core/admin/build/webhook-edit-page.********.chunk.js`	5.89 kB	0 B
`packages/core/admin/build/webhook-list-page.********.chunk.js`	3.14 kB	0 B
`packages/core/admin/build/zh-Hans-json.********.chunk.js`	17.1 kB	0 B
`packages/core/admin/build/zh-json.********.chunk.js`	15.2 kB	0 B

_{compressed-size-action}

resolves #16645

christiancp100

LGTM

innerdvations added flag: 💥 Breaking change This PR contains breaking changes and should not be merged source: core:database Source is core/database package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) version: 5 labels Oct 19, 2023

innerdvations added this to the 5.0.0 milestone Oct 19, 2023

innerdvations self-assigned this Oct 19, 2023

vercel bot deployed to Preview October 19, 2023 09:02 View deployment

innerdvations mentioned this pull request Oct 19, 2023

Update supported databases strapi/documentation#1887

Merged

innerdvations changed the base branch from v5/main to v5/drop-mysql5 October 19, 2023 10:37

innerdvations requested review from alexandrebodin, derrickmehaffy and markkaylor October 23, 2023 07:17

vercel bot deployed to Preview October 23, 2023 13:17 View deployment

innerdvations added 3 commits October 25, 2023 17:42

chore: remove support for mysql 5

5fbbe6e

remove supportsWindowFunctions

185ec13

fix broken merge

bb240a4

innerdvations force-pushed the v5/drop-mysql5 branch from f3aa5ac to bb240a4 Compare October 25, 2023 15:50

innerdvations marked this pull request as draft October 25, 2023 15:54

innerdvations and others added 5 commits October 26, 2023 12:10

chore: remove window functions checks

f678e71

chore: remove sqlite legacy and update better-sqlite3

95b5128

chore(tooling): add commitlint (#18402)

f8fd9a1

resolves #16645

fix: add client replacement map

e7841d8

chore: use better-sqlite3 9.0.0

23adb6a

innerdvations force-pushed the v5/drop-sqlite-package-support branch from 26ec26c to 23adb6a Compare October 26, 2023 12:51

innerdvations requested review from christiancp100 and Bassel17 October 26, 2023 12:52

innerdvations marked this pull request as ready for review October 26, 2023 12:53

christiancp100 approved these changes Oct 26, 2023

View reviewed changes

chore: yarn.lock

7792a95

innerdvations added 2 commits October 26, 2023 15:54

fix: remove import

61f4689

Merge branch 'v5/drop-mysql5' into v5/drop-sqlite-package-support

03067dd

Base automatically changed from v5/drop-mysql5 to v5/main October 30, 2023 11:06

Merge branch 'v5/main' into v5/drop-sqlite-package-support

6bb3b1d

vercel bot deployed to Preview October 30, 2023 11:10 View deployment

innerdvations merged commit 6d4417f into v5/main Oct 30, 2023
95 of 96 checks passed

innerdvations deleted the v5/drop-sqlite-package-support branch October 30, 2023 11:38

christiancp100 mentioned this pull request Jan 4, 2024

Only support better-sqlite3 package for sqlite #19155

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v5] Only support better-sqlite3 package for sqlite #18500

[v5] Only support better-sqlite3 package for sqlite #18500

innerdvations commented Oct 19, 2023 •

edited

github-actions bot commented Oct 19, 2023 •

edited

christiancp100 left a comment

[v5] Only support better-sqlite3 package for sqlite #18500

[v5] Only support better-sqlite3 package for sqlite #18500

Conversation

innerdvations commented Oct 19, 2023 • edited

What does it do?

Why is it needed?

How to test it?

Related issue(s)/PR(s)

github-actions bot commented Oct 19, 2023 • edited

christiancp100 left a comment

Choose a reason for hiding this comment

innerdvations commented Oct 19, 2023 •

edited

github-actions bot commented Oct 19, 2023 •

edited