Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the docker creation for macos M1 #488

Merged
merged 7 commits into from
Mar 18, 2024
Merged

Improve the docker creation for macos M1 #488

merged 7 commits into from
Mar 18, 2024

Conversation

eldraco
Copy link
Collaborator

@eldraco eldraco commented Mar 18, 2024

The docker for p2p in macos M1 was not working correctly. This solves the problem

Fixes Issue

The p2p library of slips was not correctly downloaded and executed

Changes proposed

[x] - Modify the Dockerfile for macos-m1-p2p to correctly install programs, download the p2p library and execute it

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Signed-off-by: Sebastian Garcia <eldraco@gmail.com>
Signed-off-by: Sebastian Garcia <eldraco@gmail.com>
Signed-off-by: Sebastian Garcia <eldraco@gmail.com>
Signed-off-by: Sebastian Garcia <eldraco@gmail.com>
Signed-off-by: Sebastian Garcia <eldraco@gmail.com>
…ereLinuxIPS into m1-p2p-improve

Signed-off-by: Sebastian Garcia <eldraco@gmail.com>

# Conflicts:
#	docker/macosm1-P2P-image/Dockerfile
Signed-off-by: Sebastian Garcia <eldraco@gmail.com>
@eldraco eldraco merged commit 8ce9f70 into develop Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant