Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use buffer pool #103

Closed
Tracked by #53
Fi3 opened this issue Nov 17, 2021 · 1 comment · Fixed by #170
Closed
Tracked by #53

use buffer pool #103

Fi3 opened this issue Nov 17, 2021 · 1 comment · Fixed by #170
Assignees
Labels
good first issue Good for newcomers

Comments

@Fi3
Copy link
Collaborator

Fi3 commented Nov 17, 2021

No description provided.

@rrybarczyk
Copy link
Collaborator

The Codec currently implements and exports the Buffer trait.

It should instead import use and reexport the Buffer trait from buffer-pool. Via a compile flag, we should instruct the codec to use the Buffer that is currently using either SlowAndCorrect or the one that is implemented in buffer-pool (that is faster but has some unsafe code). We should modify the sv2-ffi crate in order to use the codec with the SlowAndCorrect buffer, so at least at the beginning, we will use the safest implementation in Bitcoin Core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
No open projects
Status: Done
3 participants