First draft at returning strawberry types from mapped resolvers. #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strawberry doesn't actually type check the values returned from
resolvers -- the "self" in resolvers is really just whatever object the
parent resolver returned, transparently forwarded by strawberry. Before
this change, all of our resolvers return (and in turn only support)
"self" being an instance of a sqlalchemy model, not the strawberry type.
At best, that's confusing, but at worst, it doesn't allow manually
defined resolvers on a mapped type to call sibiling resolvers. E.g.
imagine a user-defined resolver:
This fails, because the sqlalchemy model type has no
"resolve_other_field" defined, which is perplexing, because it seems
like it should be defined. The only way to call it is like:
MyModel.resolve_other_field(self, info)
, but IMO this unnecessarilyexposes the user to strawberry internal knowledge (static method
nonsense) that they don't need to be privvy to. By instead ensuring all
of our resolvers return the strawberry type, all the typing works just
like expected.