Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Windows) Command line options not working with diacritics #1191

Closed
3 tasks done
ultr41337h4xor opened this issue Apr 26, 2023 · 3 comments
Closed
3 tasks done

(Windows) Command line options not working with diacritics #1191

ultr41337h4xor opened this issue Apr 26, 2023 · 3 comments
Assignees

Comments

@ultr41337h4xor
Copy link

ultr41337h4xor commented Apr 26, 2023

  • I have checked the FAQ for answers.
  • I have checked the Changelog that the issue is not already fixed.
  • I believe this issue is a bug, and not a general technical issue, question or feature requests that can be discussed on the forum.

Describe the bug
Trying to play a local file, when the file location contains a diacritic (for example - C:/Domaće) results in the player giving a file does not exist error. The player tries to find a file location that does not contain the diacritic (following the former example - C:/Domace).

To Reproduce
Try to play a local file in a location containg a diacritic in the name.

Expected behavior
The file should be found and played.

Screenshots:
image

System Information:

  • Operating system: Windows 10
  • Strawberry Version: 1.0.17

Additional context
/

@jonaski
Copy link
Member

jonaski commented Apr 27, 2023

I can't reproduce this issue. Tested with both "Domaće" in the path and in the filename.

What settings do you have in Windows for Region? Make sure the Beta option is off, it is buggy:

image

@ultr41337h4xor
Copy link
Author

ultr41337h4xor commented Apr 28, 2023

@jonaski
System locale is set to English (United States) with Beta unticked, while formats are set to Croatian (Croatia).

Also, to clarify further - the way I play files is I have the setting in the player for double clicking set to append to the playlist and always start playing. So, this happens when I try playing a file by double clicking it in a Windows Explorer window. Maybe that has something to do with it?

EDIT: Just tested dragging and dropping a song from that folder to the playlist, as well as going to Music - Open file... which both worked. So it seems the only time this happens is when playing by double clicking on a song in Windows Explorer.

@jonaski jonaski self-assigned this Apr 28, 2023
@jonaski jonaski changed the title File locations containing diacritics result in not being able to play local files (Windows) Command line options not working with diacritics Apr 28, 2023
@jonaski jonaski removed their assignment Apr 28, 2023
@jonaski
Copy link
Member

jonaski commented Apr 28, 2023

This is because Strawberry uses BSD getopt on Windows too, so no easy fix I think other than rewriting the command line options.

jonaski added a commit that referenced this issue Apr 30, 2023
jonaski added a commit that referenced this issue Apr 30, 2023
jonaski added a commit that referenced this issue Apr 30, 2023
jonaski added a commit that referenced this issue May 1, 2023
jonaski added a commit that referenced this issue May 1, 2023
@jonaski jonaski self-assigned this May 1, 2023
jonaski added a commit that referenced this issue May 1, 2023
jonaski added a commit that referenced this issue May 1, 2023
jonaski added a commit that referenced this issue May 1, 2023
jonaski added a commit that referenced this issue May 1, 2023
@jonaski jonaski closed this as completed in 1d3223e May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants