feat: add lib and es6 bundles, use closure compiler, remove gulp #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o fred/use-webpack * 'fred/use-webpack' of https://github.com/imgix/drift: Sync with Prettier
2 tasks
jayeb
approved these changes
Jul 12, 2018
webpack.config.js
Outdated
| const path = require("path"); | ||
| const env = require("yargs").argv.env; // use --env with webpack 2 | ||
| const pkg = require("./package.json"); | ||
| const UglifyJsPlugin = require("uglifyjs-webpack-plugin"); |
There was a problem hiding this comment.
This doesn't appear to be used in this file.
bower.json
Outdated
| @@ -25,7 +25,6 @@ | |||
| "src", | |||
| "test", | |||
| "CONTRIBUTING.md", | |||
| "gulpfile.js", | |||
| "index.html", | |||
| "karmaConfig.js", | |||
There was a problem hiding this comment.
Some of the files in this list need updating
CONTRIBUTING.md
Outdated
| gulp test-local # run the test against local browsers only (Chrome, Safari, Firefox) | ||
| gulp test-full # run the test suite against all supported browsers (using SauceLabs) | ||
| npm run build # build Drift from source | ||
| npm run build:watch # watch for changes and build automatically |
There was a problem hiding this comment.
[nit] Handsome tab spacing is broken here
|
👏This looks awesome! Also, that run-p package seems really nice. Looks as though it would make working with scripts much easier. |
…o fred/use-webpack * 'fred/use-webpack' of https://github.com/imgix/drift: chore(CONTRIBUTING): fix tab alignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the build step of this library. The minified JS build is reduced from
18K -> 11K = 40% smaller. The css size is unchanged.There have been some changes to the source code to support the closure compiler. There might be a chance that things that worked before may not work now due to the optimisations it performs. I have tried to cover all common usage, but there may be some edge cases which I have not tested. All the tests still pass, and I've ensured that the tests test the compiled code.
Gulp has also been removed in favour of npm scripts.
New Feature
feat(<area>): added new way to do this cool thing #issue-numberSteps to Test
npm installto update dependenciesnpm run buildand openindex.htmlin a browser, and test that Drift still works normallyimport Drift from 'drift-zoom'