fix: fix arrow navigation #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayeb
approved these changes
Nov 19, 2018
|
@jayeb I don't believe there are any tests for this behavior - shall I add some? |
|
Yes please! |
…into fred/fix-arrow-nav * 'fred/fix-arrow-nav' of https://github.com/imgix/luminous: chore(deps): update dependency karma-jasmine to v2.0.1 (#120) chore(deps): update dependency karma-jasmine to v2 (#119) chore(deps): update babel monorepo to v7.1.6 (#118) chore(deps): update dependency eslint-config-prettier to v3.3.0 (#117) chore(deps): update dependency eslint-config-prettier to v3.2.0 (#116) chore(deps): update dependency prettier to v1.15.2 (#115) chore(deps): update dependency eslint to v5.9.0 (#114)
|
@jayeb Can you give this another review? I've added some tests for LuminousGallery |
jayeb
approved these changes
Nov 26, 2018
|
There's something strange going on with Closure - I'll have to have a look tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a regression in a previous release of this library, where arrow navigation was broken.
The problem was that when the Closure compiler was integrated into this library, the way the settings were passed around the objects was broken as Closure rewrites object key names. This fixes that.
Fixes #74
Bug Fix
fix(<area>): fixed bug #issue-numberSteps to Test
Check that tests still pass.
To test locally:
npm install && npm run buildindex.htmlin a browser