Allow version range for windows dependency
#112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`iana-time-zone` works with any `windows` version since `0.30.0`. We don't have to care which version the user actually uses. We only need to make sure that the selected version is not too old. Let `cargo` decide everything else. The newest version of `windows`, `0.51.0`, has an msrv of `1.56`. If a user of `iana-time-zone` is not able or willing to update their rust installation, and want to continue using rustc `1.48`, they can select an older version of the `windows` crate, and still receive any updates `iana-time-zone` might have in the future.
Kijewski
added
dependencies
|
FYI if the MSRV range wasn't this strict this crate could migrate to Maybe something for the future 👍 |
|
This is redundant now with other recent merges. Closing, but please re-open (and update) if this is in error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iana-time-zoneworks with anywindowsversion since0.30.0. We don't have to care which version the user actually uses. We only need to make sure that the selected version is not too old. Letcargodecide everything else.The newest version of
windows,0.51.0, has an msrv of1.56. If a user ofiana-time-zoneis not able or willing to update their rust installation, and want to continue using rustc1.48, they can select an older version of thewindowscrate, and still receive any updatesiana-time-zonemight have in the future.Resolves #111.