Implement for wasm #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kijewski
force-pushed
the
pr-wasm
branch
2 times, most recently
from
8672c11
to
60e7b44
Compare
<code>[Intl.DateTimeFormat()]</code> makes the timezone of the browser or node instance queryable, and [is available] in all browsers that support WASM. [Intl.DateTimeFormat()]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/DateTimeFormat [is available]: https://caniuse.com/mdn-javascript_builtins_intl_datetimeformat_resolvedoptions
|
Nice. thanks. Released as 0.1.34. |
Kijewski
added a commit
to Kijewski/iana-time-zone
that referenced
this pull request
Jul 21, 2022
PR strawlab#38 did not properly separate WebAssembly for the use in a browser/nodejs, or standalone run in e.g. wasmtime. This PR make the compilation fail if the target-os is WASI. Also I deduplicated the imports by using `#[cfg_attr(…, path = …)]` instead of importing and aliassing in two steps.
Merged
djc
added a commit
to djc/iana-time-zone
that referenced
this pull request
Sep 12, 2022
WebAssembly support was added in strawlab#38 targeting the current versions versions of wasm-bindgen and js-sys at the time, which is reasonable. Unfortunately the whoami crate, in trying to support older Rust versions, has reduced the upper version of wasm-bindgen that it supports, see ardaku/whoami#43. This PR thus reduces the minimum version required for wasm-bindgen. I used `cargo +nightly update -Z minimal-versions` with `cargo build --target wasm32-unknown-unknown` to find the earliest version that compiles. We could theoretically set up checks in CI to verify this on an ongoing basis, but this might be overkill for now.
Kijewski
pushed a commit
that referenced
this pull request
Sep 12, 2022
WebAssembly support was added in #38 targeting the current versions versions of wasm-bindgen and js-sys at the time, which is reasonable. Unfortunately the whoami crate, in trying to support older Rust versions, has reduced the upper version of wasm-bindgen that it supports, see ardaku/whoami#43. This PR thus reduces the minimum version required for wasm-bindgen. I used `cargo +nightly update -Z minimal-versions` with `cargo build --target wasm32-unknown-unknown` to find the earliest version that compiles. We could theoretically set up checks in CI to verify this on an ongoing basis, but this might be overkill for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intl.DateTimeFormat()makes the timezone of the browser or node instance queryable, and is available in all browsers that support WASM.