Correct Stripe token length and endpoint #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing one gave the following error:
```
{
"error": {
"message": "Unrecognized request URL (GET: /v1/). If you are trying to list objects, remove the trailing slash. If you are trying to retrieve an object, make sure you passed a valid (non-empty) identifier in your code. Please see https://stripe.com/docs or we can help at https://support.stripe.com/.",
"type": "invalid_request_error"
}
}
```
KevinHock
commented
Sep 21, 2019
| @@ -424,14 +424,11 @@ curl -v -X GET "https://api.sandbox.paypal.com/v1/identity/oauth2/userinfo?schem | |||
| ## [Stripe Live Token](https://stripe.com/docs/api/authentication) | |||
|
|
|||
| ``` | |||
|
|
|||
| curl https://api.stripe.com/v1/ | |||
There was a problem hiding this comment.
While it is true that this doesn't work currently, restricted keys can be restricted to certain endpoints. It would be really nice not to have to loop through their endpoints to tell if there is a valid key. I will investigate if this is possible.
KevinHock
changed the title
|
Not ignoring this one, but away at BSides. If @streaak and @EdOverflow are unable to get to this by Monday afternoon I'll review and merge it for you. |
|
Hey @KevinHock, |
|
Sounds great @streaak, thank you both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
34->24Many secret detection tools can testify to this, like
detect-secrets