Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix(sources): force timestamp sync mode for NDI sources #4928

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/services/sources/sources.ts
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,14 @@ export class SourcesService extends StatefulService<ISourcesState> {
resolvedSettings.device = this.defaultHardwareService.state.defaultVideoDevice;
}

// TODO: this is looking more and more like a backend fix is needed instead
// Set sync mode to Network (or whatever option 1 is for NDI sources, called timestamp on their end)
// I still can't get preview to show until I change any setting in the source
if (type === 'ndi_source' && typeof resolvedSettings.ndi_sync === 'undefined') {
const NDI_SYNC_TIMESTAMP = 1;
resolvedSettings.ndi_sync = NDI_SYNC_TIMESTAMP;
}

return resolvedSettings;
}

Expand Down
Loading