Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disable JS compilation #122

Merged
merged 2 commits into from
Apr 21, 2020
Merged

chore: Disable JS compilation #122

merged 2 commits into from
Apr 21, 2020

Conversation

orestes
Copy link
Collaborator

@orestes orestes commented Apr 21, 2020

Related to #50

This PR disables JS compilation in tsc
It also removes a redundant exclude of the config file for prettier

@orestes orestes requested a review from SantiMA10 April 21, 2020 21:04
@orestes orestes added the enhancement General enhancement label Apr 21, 2020
@SantiMA10 SantiMA10 mentioned this pull request Apr 21, 2020
28 tasks
@@ -63,5 +63,5 @@
/* Advanced Options */
"forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */
},
"exclude": ["prettier.config.js", "dist/*"]
"exclude": ["dist/*"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor

@SantiMA10 SantiMA10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@SantiMA10 SantiMA10 merged commit 23410b7 into master Apr 21, 2020
@SantiMA10 SantiMA10 deleted the 50-no-more-js branch April 21, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants