creates undefined directories

[heygrady]

Was comparing memfs and memory-fs and was failing a test. Discovered that memfs will create undefined directories when you fs.mkdirSync("/"); and that directory already exists.

// test.js
const {Volume} = require("memfs");

var fs = new Volume();

// snippet from https://github.com/webpack/memory-fs/blob/master/test/MemoryFileSystem.js#L18
fs.mkdirSync("/test");
console.log(fs.readdirSync("/"));
fs.mkdirSync("/test//sub/");
console.log(fs.readdirSync("/"));
fs.mkdirpSync("/test/sub2");
console.log(fs.readdirSync("/"));
fs.mkdirSync("/root\\dir");
console.log(fs.readdirSync("/"));
fs.mkdirpSync("/");
console.log(fs.readdirSync("/"));
fs.mkdirSync("/"); // <-- this should probably throw; creates an "undefined" folder instead
console.log(fs.readdirSync("/")); // --> [ 'root\\dir', 'test', 'undefined' ]

$ node test.js
[ 'test' ]
[ 'test' ]
[ 'test' ]
[ 'root\\dir', 'test' ]
[ 'root\\dir', 'test' ]
[ 'root\\dir', 'test', 'undefined' ]

[heygrady]

I created a fork of memory-fs and tried to replace it with Volume. It's mostly working but some tests are failing. Most of the test failures are related to streams.

https://github.com/heygrady/memory-fs/tree/memfs

There are also some failures related to windows-style paths. I think those might be due to memory-fs using a normalize function on all paths and I didn't wrap the memfs methods to do that. (#327)

I'm exploring easy ways to make memory-fs API-compliant to work with webpack-dev-server.

webpack/webpack-dev-middleware#366

[streamich]

Thanks for reporting this! If you have examples of bugs related to streams, I would kindly ask you to open a new issue.

[streamich]

🎉 This issue has been resolved in version 2.15.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[heygrady]

The streams issue was a false alarm. Turns out that streams in memory-fs don't work the same as fs and memfs. I think memfs has a more-correct implementation and I corrected the tests in my branch to follow the memfs/fs way.

[streamich]

Im memfs stream implementation is copied from Node almost verbatim.