Throw error with correct code when node exists #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've the following helper method to create directories:
Unfortunately, this doesn't work with
memfs
, asaddDir
/addFile
will throw a non-system error if a node exists (with no code defined).This PR throws an error closer to what Node itself would actually throw: https://nodejs.org/api/errors.html#errors_system_errors
Lemme know if you need me to change anything about this PR to get it merged in. Really enjoyed working with
memfs
, particularly for testing. Thanks for your hard work!