ENOENT: no such file or directory, scandir

[l1bbcsg]

This regression was introduced in 4.2.0
4.1.0 and prior work as expected.
Node version is v10.12.0

Sample code:

const realFs = require('fs');
const virtualFs = new (require('memfs').Volume)();
const unionFs = new (require('unionfs').Union)();

virtualFs.fromJSON({
	'does-not-exist-in-real-fs/file.txt': ''
});

unionFs.use(virtualFs);
unionFs.use(realFs);

try { console.log('realFs',    realFs.readdirSync('does-not-exist-in-real-fs'));    } catch(e) {console.error(e.message)}
try { console.log('virtualFs', virtualFs.readdirSync('does-not-exist-in-real-fs')); } catch(e) {console.error(e.message)}
try { console.log('unionFs',   unionFs.readdirSync('does-not-exist-in-real-fs'));   } catch(e) {console.error(e.message)}

Expected result:

Directory can be read in virtual fs, union fs but not real fs.

ENOENT: no such file or directory, scandir 'does-not-exist-in-real-fs'
virtualFs [ 'file.txt' ]
unionFs [ 'file.txt' ]

Actual result:

Directory can be read in virtual fs, but not union fs and real fs.

ENOENT: no such file or directory, scandir 'does-not-exist-in-real-fs'
virtualFs [ 'file.txt' ]
ENOENT: no such file or directory, scandir 'does-not-exist-in-real-fs'

[Sleepful]

Same issue, readdirSync('/') does actually work, but once I try any path other than / it crashes with

node_modules\unionfs\lib\union.js:233
                    throw err;
                    ^

Error: ENOENT: no such file or directory, scandir '/dist'

even though I can read the files in those paths like so ufs.readFileSync('/src/index.html', 'utf8')

I also tried to downgrade by doing npm install unionfs@4.1.0 but I still have the same issue, however in previous versions the issue exists only when accessing memfs filesystem, in the previous versions I can access the system's fs filesystem. In latest version both give errors.

---

Quick Fix

Comment out line 288 in node_modules\unionfs\lib\union.js (this is the line in the .ts), I believe this throws an error when it fails to find a directory in one filesystem and then it stops trying to find it on the other filesystems, if you comment out the line: throw err below if (!i) { // last one then it finds the directory but it won't throw error if the directory doesn't exist in any of the filesystems

[streamich]

🎉 This issue has been resolved in version 4.2.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀