Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker show value #2817

Merged
merged 3 commits into from
Feb 18, 2021

Conversation

karriebear
Copy link
Contributor

Add optional show value option
image


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@karriebear karriebear marked this pull request as ready for review February 18, 2021 20:09
@karriebear karriebear requested a review from a team February 18, 2021 20:09
Copy link
Collaborator

@vdonato vdonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add to an an assertion to an existing test that the color value doesn't show up by default / add a new test that it does when showValue === true, but LGTM once that's done

@karriebear karriebear merged commit 137d8fa into streamlit:develop Feb 18, 2021
@karriebear karriebear deleted the color-picker-show-value branch February 18, 2021 22:22
schaumb pushed a commit to FloWide/streamlit that referenced this pull request Feb 22, 2021
* Adjust color picker UI + add show value option

* Fix tests

* add test
tconkling added a commit to tconkling/streamlit that referenced this pull request Feb 22, 2021
* develop:
  Color picker - show value (streamlit#2817)
  Minor improvements to local E2E testing  (streamlit#2807)
  Fix datetime timezone handling in data frames (streamlit#2784)
  Remove nonexistent elements from widget state (streamlit#2760)
  Shared selectbox (streamlit#2795)
tconkling added a commit to tconkling/streamlit that referenced this pull request Feb 24, 2021
* develop:
  Update "showErrorDetails" config description and docs (streamlit#2841)
  Pause Dependabot updates for non-security-related issues (streamlit#2840)
  client.showTracebacks -> showErrorDetails (per product) (streamlit#2837)
  Color picker - show value (streamlit#2817)
  Minor improvements to local E2E testing  (streamlit#2807)
  Fix datetime timezone handling in data frames (streamlit#2784)
  Remove nonexistent elements from widget state (streamlit#2760)
  Shared selectbox (streamlit#2795)
tconkling added a commit that referenced this pull request Mar 1, 2021
* develop: (29 commits)
  Update bug_report.md
  Refactor CodeBlock.tsx (#2814)
  Remove copy button for empty codeblocks (#2808)
  Add image format deprecation config with expiration (#2865)
  Remove unneeded "use_column_width=True" from our doc examples (#2692)
  Extend our st.cache MagicMock handling logic to Mock (#2846)
  save work (#2862)
  Remove .stale-element class (#2848)
  Release 0.77 (#2849)
  Fix watchdog import failure (#2856)
  🔥 Fully remove `format` param from st.image (#2637)
  Don't memoize config._server_headless (#2858)
  hide empty columns on mobile (#2756)
  st.beta_secrets (#2757)
  `watch_file` utility function (#2851)
  Align st.beta_columns  (#2811)
  Update "showErrorDetails" config description and docs (#2841)
  Pause Dependabot updates for non-security-related issues (#2840)
  client.showTracebacks -> showErrorDetails (per product) (#2837)
  Color picker - show value (#2817)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants