Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.showTracebacks -> showErrorDetails (per product) #2837

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

tconkling
Copy link
Contributor

A simple rename: client.showTracebacks config option is now client.showErrorDetails. (This was requested here: #2770 (comment))

We haven't pushed a release that uses the "showTracebacks" name, so we can get away without a warning about a deprecated config option.

@tconkling tconkling requested a review from a team February 22, 2021 18:23
# frontend when we encounter an uncaught app exception.
_GENERIC_UNCAUGHT_EXCEPTION_TEXT = (
"Whoops - something went wrong! An error has been logged."
"Whoops something went wrong! An error has been logged."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dash -> emdash, per Thiago!

@tconkling tconkling merged commit dfbfe34 into streamlit:develop Feb 22, 2021
@tconkling tconkling deleted the tim/ShowErrorDetailsConfig branch February 22, 2021 23:26
tconkling added a commit to tconkling/streamlit that referenced this pull request Feb 23, 2021
* develop:
  Update "showErrorDetails" config description and docs (streamlit#2841)
  Pause Dependabot updates for non-security-related issues (streamlit#2840)
  client.showTracebacks -> showErrorDetails (per product) (streamlit#2837)
tconkling added a commit to tconkling/streamlit that referenced this pull request Feb 24, 2021
* develop:
  Update "showErrorDetails" config description and docs (streamlit#2841)
  Pause Dependabot updates for non-security-related issues (streamlit#2840)
  client.showTracebacks -> showErrorDetails (per product) (streamlit#2837)
  Color picker - show value (streamlit#2817)
  Minor improvements to local E2E testing  (streamlit#2807)
  Fix datetime timezone handling in data frames (streamlit#2784)
  Remove nonexistent elements from widget state (streamlit#2760)
  Shared selectbox (streamlit#2795)
ghost pushed a commit that referenced this pull request Feb 25, 2021
* Up version to 0.77.0

* client.showTracebacks -> showErrorDetails (per product) (#2837)

A simple rename: `client.showTracebacks` config option is now `client.showErrorDetails`. (This was requested here: #2770 (comment))

We haven't pushed a release that uses the "showTracebacks" name, so we can get away without a warning about a deprecated config option.

* Update "showErrorDetails" config description and docs (#2841)

New config description, and an updated docs page.

* fix typo in changelog

Co-authored-by: Tim Conkling <tconkling@gmail.com>
tconkling added a commit that referenced this pull request Mar 1, 2021
* develop: (29 commits)
  Update bug_report.md
  Refactor CodeBlock.tsx (#2814)
  Remove copy button for empty codeblocks (#2808)
  Add image format deprecation config with expiration (#2865)
  Remove unneeded "use_column_width=True" from our doc examples (#2692)
  Extend our st.cache MagicMock handling logic to Mock (#2846)
  save work (#2862)
  Remove .stale-element class (#2848)
  Release 0.77 (#2849)
  Fix watchdog import failure (#2856)
  🔥 Fully remove `format` param from st.image (#2637)
  Don't memoize config._server_headless (#2858)
  hide empty columns on mobile (#2756)
  st.beta_secrets (#2757)
  `watch_file` utility function (#2851)
  Align st.beta_columns  (#2811)
  Update "showErrorDetails" config description and docs (#2841)
  Pause Dependabot updates for non-security-related issues (#2840)
  client.showTracebacks -> showErrorDetails (per product) (#2837)
  Color picker - show value (#2817)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants