-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client.showTracebacks -> showErrorDetails (per product) #2837
Merged
tconkling
merged 1 commit into
streamlit:develop
from
tconkling:tim/ShowErrorDetailsConfig
Feb 22, 2021
Merged
client.showTracebacks -> showErrorDetails (per product) #2837
tconkling
merged 1 commit into
streamlit:develop
from
tconkling:tim/ShowErrorDetailsConfig
Feb 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconkling
commented
Feb 22, 2021
# frontend when we encounter an uncaught app exception. | ||
_GENERIC_UNCAUGHT_EXCEPTION_TEXT = ( | ||
"Whoops - something went wrong! An error has been logged." | ||
"Whoops — something went wrong! An error has been logged." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dash -> emdash, per Thiago!
karriebear
approved these changes
Feb 22, 2021
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Feb 23, 2021
* develop: Update "showErrorDetails" config description and docs (streamlit#2841) Pause Dependabot updates for non-security-related issues (streamlit#2840) client.showTracebacks -> showErrorDetails (per product) (streamlit#2837)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Feb 24, 2021
* develop: Update "showErrorDetails" config description and docs (streamlit#2841) Pause Dependabot updates for non-security-related issues (streamlit#2840) client.showTracebacks -> showErrorDetails (per product) (streamlit#2837) Color picker - show value (streamlit#2817) Minor improvements to local E2E testing (streamlit#2807) Fix datetime timezone handling in data frames (streamlit#2784) Remove nonexistent elements from widget state (streamlit#2760) Shared selectbox (streamlit#2795)
ghost
pushed a commit
that referenced
this pull request
Feb 25, 2021
* Up version to 0.77.0 * client.showTracebacks -> showErrorDetails (per product) (#2837) A simple rename: `client.showTracebacks` config option is now `client.showErrorDetails`. (This was requested here: #2770 (comment)) We haven't pushed a release that uses the "showTracebacks" name, so we can get away without a warning about a deprecated config option. * Update "showErrorDetails" config description and docs (#2841) New config description, and an updated docs page. * fix typo in changelog Co-authored-by: Tim Conkling <tconkling@gmail.com>
tconkling
added a commit
that referenced
this pull request
Mar 1, 2021
* develop: (29 commits) Update bug_report.md Refactor CodeBlock.tsx (#2814) Remove copy button for empty codeblocks (#2808) Add image format deprecation config with expiration (#2865) Remove unneeded "use_column_width=True" from our doc examples (#2692) Extend our st.cache MagicMock handling logic to Mock (#2846) save work (#2862) Remove .stale-element class (#2848) Release 0.77 (#2849) Fix watchdog import failure (#2856) 🔥 Fully remove `format` param from st.image (#2637) Don't memoize config._server_headless (#2858) hide empty columns on mobile (#2756) st.beta_secrets (#2757) `watch_file` utility function (#2851) Align st.beta_columns (#2811) Update "showErrorDetails" config description and docs (#2841) Pause Dependabot updates for non-security-related issues (#2840) client.showTracebacks -> showErrorDetails (per product) (#2837) Color picker - show value (#2817) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple rename:
client.showTracebacks
config option is nowclient.showErrorDetails
. (This was requested here: #2770 (comment))We haven't pushed a release that uses the "showTracebacks" name, so we can get away without a warning about a deprecated config option.