Extend our st.cache MagicMock handling logic to Mock #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
tconkling
suggested changes
Feb 24, 2021
There was a problem hiding this comment.
Looks good, just needs a test.
Can we do isinstance(obj, unittest.mock.Mock) instead of testing for the exact class names? (MagicMock is a subclass of Mock, so this test would catch both of those.)
I don't think we actually need to test for mock.mock.Mock anymore; now that we're on Python 3, Mock/MagicMock is guaranteed to be in the standard library, which means we can also import Mock safely in this file without testing against the classes' name strings.
tconkling
approved these changes
Feb 24, 2021
sthagen
added a commit
to sthagen/streamlit-streamlit
that referenced
this pull request
Feb 26, 2021
Extend our st.cache MagicMock handling logic to Mock (streamlit#2846)
tconkling
added a commit
that referenced
this pull request
Mar 1, 2021
* develop: (29 commits) Update bug_report.md Refactor CodeBlock.tsx (#2814) Remove copy button for empty codeblocks (#2808) Add image format deprecation config with expiration (#2865) Remove unneeded "use_column_width=True" from our doc examples (#2692) Extend our st.cache MagicMock handling logic to Mock (#2846) save work (#2862) Remove .stale-element class (#2848) Release 0.77 (#2849) Fix watchdog import failure (#2856) 🔥 Fully remove `format` param from st.image (#2637) Don't memoize config._server_headless (#2858) hide empty columns on mobile (#2756) st.beta_secrets (#2757) `watch_file` utility function (#2851) Align st.beta_columns (#2811) Update "showErrorDetails" config description and docs (#2841) Pause Dependabot updates for non-security-related issues (#2840) client.showTracebacks -> showErrorDetails (per product) (#2837) Color picker - show value (#2817) ...
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2813.
In
st.cache(), we currently don't hashMagicMockobjects because they can cause an infinite recursion.Mockobjects suffer the same problem, so this PR extends the logic to cover those as well.