Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix AoP can't work when enabling Pulsar transaction #1070

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

gaoran10
Copy link
Collaborator

@gaoran10 gaoran10 commented Dec 4, 2023

Motivation

Currently, AoP can't read messages and deliver them when enabling Pulsar transaction, it's due to that the max read position didn't refresh after messages were published.

Modifications

Update max read position while messages are published.

Verifying this change

Add a test to verify that AoP works well when enabling Pulsar transaction.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@gaoran10 gaoran10 self-assigned this Dec 4, 2023
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Dec 4, 2023
@GhostBoyBoy
Copy link
Contributor

GhostBoyBoy commented Dec 4, 2023

Do multiple bundle scenarios require testing?

@gaoran10
Copy link
Collaborator Author

gaoran10 commented Dec 5, 2023

Do multiple bundle scenarios require testing?

I think the multi-bundle case doesn't have this problem, because when enabling the multi-bundle messages will be published by producers, I'll have a try.

@gaoran10
Copy link
Collaborator Author

gaoran10 commented Jan 5, 2024

@GhostBoyBoy I enable transactions in tests, the multi-bundle test will also apply this change.

@codelipenghui codelipenghui merged commit bdf590e into streamnative:master Apr 28, 2024
3 checks passed
@gaoran10 gaoran10 deleted the fix-work-with-pulsar-txn branch April 28, 2024 16:42
gaoran10 added a commit that referenced this pull request Apr 28, 2024
gaoran10 added a commit that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants