Walk around the Pulsar deduplication check #530
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the AoP couldn't work with the Pulsar deduplication feature, and it seems the AMQP protocol doesn't support the message deduplication feature. So we could walk around the Pulsar deduplication check when publishing messages in AoP.
Modifications
Add a new class
AmqpEntryWriter
to process messages publishing, and use the methodManagedLedger#asyncAddEntry
instead ofPersistentTopic#publishMessage
to write messages.Verifying this change
Add a new test to verify the AoP could work well when enabling message deduplication in Pulsar.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)