Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walk around the Pulsar deduplication check #530

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

gaoran10
Copy link
Collaborator

@gaoran10 gaoran10 commented May 9, 2022

Motivation

Currently, the AoP couldn't work with the Pulsar deduplication feature, and it seems the AMQP protocol doesn't support the message deduplication feature. So we could walk around the Pulsar deduplication check when publishing messages in AoP.

Modifications

Add a new class AmqpEntryWriter to process messages publishing, and use the method ManagedLedger#asyncAddEntry instead of PersistentTopic#publishMessage to write messages.

Verifying this change

Add a new test to verify the AoP could work well when enabling message deduplication in Pulsar.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@gaoran10 gaoran10 requested review from codelipenghui and a team as code owners May 9, 2022 13:47
@github-actions github-actions bot added the no-need-doc This pr does not need any document label May 9, 2022
@gaoran10 gaoran10 merged commit 83276d8 into streamnative:master Jun 8, 2022
@GhostBoyBoy GhostBoyBoy mentioned this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant