Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Default echange consume failed, when broker restart. #597

Conversation

autumnqfeng
Copy link
Contributor

Master Issue: #596

Motivation

The queue corresponding to the default Exchange cannot consume messages when the broker restarts or the namespace migrates to another broker.

Modifications

Unload or broker restart can still consume normally.

Verifying this change

Set<AmqpQueue> queues in Exchange cannot be persisted after the broker has restarted. Queue validation was added to the BasicPublish interface.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jul 6, 2022
Copy link
Collaborator

@gaoran10 gaoran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for your contribution.

It seems that the root cause is the bound queue to the default exchange was not loaded when the messages in the default exchange started routing. Maybe the PR #554 can resolve this problem, I think this PR can add a double-check.

@gaoran10 gaoran10 merged commit 74d7265 into streamnative:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants