Support using sidecar to routing pod logs to Pulsar topics #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlu90
reviewed
Aug 9, 2023
pkg/webhook/sink_webhook.go
Outdated
| @@ -124,6 +124,11 @@ func (webhook *SinkWebhook) Default(ctx context.Context, obj runtime.Object) err | |||
| if r.Spec.Input.TypeClassName == "" { | |||
| r.Spec.Input.TypeClassName = "[B" | |||
| } | |||
|
|
|||
| if r.Spec.LogTopicAgent == "" { | |||
| r.Spec.LogTopicAgent = v1alpha1.RUNTIME | |||
There was a problem hiding this comment.
as discussed, for connectors we should use SIDECAR since the pulsar doesn't support log-topic for connectors natively
nlu90
reviewed
Aug 9, 2023
Comment on lines
+60
to
+61
| LogTopic string `json:"logTopic,omitempty"` | ||
| LogTopicAgent LogTopicAgent `json:"logTopicAgent,omitempty"` |
There was a problem hiding this comment.
We need to document the relationship between these two fields.
freeznet
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #663
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Support using sidecar to routing pod logs to Pulsar topics
Modifications
logTopicAgentfield to function/sink/source spec, which can be eithersidecarorruntime, when it issidecar, a sidecar container will be added to send all logs to a Pulsar topic using plugin: https://github.com/streamnative/pulsar-beat-output/Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)