Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regex to check whether runner image has pulsarctl #682

Merged

Conversation

jiangpengcheng
Copy link
Member

@jiangpengcheng jiangpengcheng commented Aug 21, 2023

Motivation

Some runner images(such as pulsar-functions-sn-java-runner) may has pulsarctl in /pulsar/bin dir, but we are using /usr/local/bin/pulsarctl as the pulsarctl path, so it's better to use pulsarctl directly and add /pulsar/bin to the $PATH

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@jiangpengcheng jiangpengcheng requested review from nlu90, freeznet and a team as code owners August 21, 2023 02:05
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Aug 21, 2023
@jiangpengcheng jiangpengcheng changed the title Copy /pulsar/bin/pulsarctl to /usr/local/bin when it exists Use regex to check whether runner image has pulsarctl Aug 24, 2023
@jiangpengcheng jiangpengcheng merged commit de8f46c into streamnative:master Aug 24, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m/2023-08 no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants