Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored Put & Delete options #144

Merged
merged 1 commit into from
May 2, 2024
Merged

Refactored Put & Delete options #144

merged 1 commit into from
May 2, 2024

Conversation

merlimat
Copy link
Collaborator

@merlimat merlimat commented May 2, 2024

  • Avoid expensive allocations during validation in the hot path
  • Take Set<PutOption> instead of PutOption... because it will make it easier for complex wrappers to use

@merlimat merlimat merged commit f3f6a31 into streamnative:main May 2, 2024
1 check passed
@merlimat merlimat deleted the refactor-options branch May 2, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattisonchao mattisonchao Awaiting requested review from mattisonchao mattisonchao is a code owner

@coderzc coderzc Awaiting requested review from coderzc coderzc is a code owner

@RobertIndie RobertIndie Awaiting requested review from RobertIndie RobertIndie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@merlimat