Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit producer batch messages by size in bytes as well #268

Open
AfonsoRibeiro opened this issue Mar 26, 2023 · 2 comments
Open

Limit producer batch messages by size in bytes as well #268

AfonsoRibeiro opened this issue Mar 26, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AfonsoRibeiro
Copy link
Contributor

To prevent the producer from sending batches that are bigger than allowed by the pulsar server, a limit in bytes should be possible to configure.
Or at least a soft threshold that when reached sends the batch (much easier to implement and it appears it is also done in the go client).
@AfonsoRibeiro AfonsoRibeiro changed the title Limitit producer batch messages by size in bytes as well Limit producer batch messages by size in bytes as well Mar 26, 2023
@AfonsoRibeiro AfonsoRibeiro mentioned this issue Mar 26, 2023
Merged
@tisonkun
Copy link
Contributor

tisonkun commented Apr 16, 2023 •
edited
Loading

This is partially resolved by #269.

Keep open for a while since there are still several potential improvements can be made. See #269 (review).

@tisonkun tisonkun added help wanted Extra attention is needed good first issue Good for newcomers enhancement New feature or request labels Apr 16, 2023
@fatelei
Copy link

fatelei commented Apr 16, 2023

i want to try this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fatelei @tisonkun @AfonsoRibeiro